sort: apply justice filters to the visible cases tab - #5927
Open
Alistair-Afton wants to merge 1 commit into
Open
Alistair-Afton wants to merge 1 commit into
Alistair-Afton wants to merge 1 commit into
Conversation
get_unit_list() looked up the "Open cases" unit list by name first, but named widget lookup finds hidden tabs too, so the filter was always installed on (and refreshes poked) the hidden list while the Cold cases tab was shown. Iterate the Tabs children and use the tab flagged VISIBILITY_VISIBLE, matching Gui.cpp's focus-string logic. Fixes DFHack#5577
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfhack.gui.getWidgetfinds hidden tabs by name tooget_unit_listnow iterates theTabschildren and uses the tab flaggedVISIBILITY_VISIBLE, matching the logicGui.cppuses to build focus stringspoke_listnow tolerates a missing unit list instead of erroringFixes #5577
Testing
test/plugins/sort.luamock the justice tab hierarchy and verify the resort flag lands on the visible tab'sInterrogate/Convictlist for both Open cases and Cold cases, and thatrender()installs the filter on the visible listVISIBILITY_VISIBLEflags match the mocked structure